Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectum based scraper #1000

Merged
merged 11 commits into from
May 5, 2024
Merged

Connectum based scraper #1000

merged 11 commits into from
May 5, 2024

Conversation

CommanderStorm
Copy link
Member

@CommanderStorm CommanderStorm commented Mar 1, 2024

Resolves #177

Proposed Changes (include Screenshots if possible)

  • Migrates the data backedn to the much more saner (= higher confidence) Connectum api backend
  • Adapts all upsteam usages to said data

TODO:

  • add missing alt_name to the api
  • add an api to read buildings (was forgotten)
  • upstream parts of the sanatsation logic

How to test this PR

  1. Look through the diff of the scraped vs downloaded data
  2. look at the generated final file
  3. let the data pipeline run

How has this been tested?

  • currently not

Checklist

  • I have updated the documentation
  • I have run the linter

@CommanderStorm CommanderStorm force-pushed the connectum-based-scraper branch from 569f48d to 1834db7 Compare May 4, 2024 18:20
@CommanderStorm CommanderStorm marked this pull request as ready for review May 5, 2024 02:34
@CommanderStorm CommanderStorm force-pushed the connectum-based-scraper branch from e58e5bb to b06edf1 Compare May 5, 2024 14:05
@CommanderStorm CommanderStorm enabled auto-merge (squash) May 5, 2024 15:33
@CommanderStorm CommanderStorm merged commit 080182c into main May 5, 2024
14 checks passed
@CommanderStorm CommanderStorm deleted the connectum-based-scraper branch May 5, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Some rooms are missing in NavigaTUM
1 participant